Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entoas: add annotation to support custom oas types #168

Merged
merged 2 commits into from
Nov 24, 2021
Merged

entoas: add annotation to support custom oas types #168

merged 2 commits into from
Nov 24, 2021

Conversation

masseelch
Copy link
Collaborator

This PR adds an Annotation to create an OAS type to use for custom GoTypes.

@masseelch masseelch marked this pull request as ready for review November 23, 2021 15:50
a8m
a8m approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Don't you want to add a test case for this?

entoas/annotation.go Outdated Show resolved Hide resolved
@masseelch @a8m
Update entoas/annotation.go
a4942a5 
Co-authored-by: Ariel Mashraki <7413593+a8m@users.noreply.github.com>
@masseelch
Copy link
Collaborator Author

Looks good. Don't you want to add a test case for this?

There is one. Or do you mean an integration one?

@a8m a8m merged commit 6afcfab into ent:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a8m a8m a8m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masseelch @a8m