Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly integrate with Tox logging/reporter functionality #3

Closed
enpaul opened this issue Sep 29, 2020 · 0 comments · Fixed by #30
Closed

Properly integrate with Tox logging/reporter functionality #3

enpaul opened this issue Sep 29, 2020 · 0 comments · Fixed by #30
Labels
feature New feature or request

Comments

@enpaul
Copy link
Owner

enpaul commented Sep 29, 2020

I suspect that this plugin is not using Tox's logging/reporter functionality properly. I suspect this because I haven't actually looked at how to do it properly. The current usage of Tox's reporter module in the plugin is trivially functional, which is all I needed, but it should be updated to log to the proper environment logger.

I need to take a closer look at Tox's logging/reporter functionality and find a better way to log the main display messages (currently the reporter.verbosity0(...) calls in the plugin). I haven't been able to find anything in the Tox documentation about the logging model so I expect other plugins and the source for tox.reporter will be the best resources.

@enpaul enpaul added feature New feature or request roadmap-beta labels Sep 29, 2020
enpaul added a commit that referenced this issue Dec 4, 2020
Standardize language in logging messages
Move system version to constants

Fixes #3
@enpaul enpaul closed this as completed in #30 Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant