Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: yarn up 'ses@workspace:^' '@endo/*@workspace:^' #2416

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

michaelfig
Copy link
Member

Refs: #2245

Description

Newer Yarn versions permit workspace-relative package references. This PR uses them to reduce version churn in yarn.lock and the dependencies sections of each package.json. A new version of Lerna supports this feature, so upgrade that, too.

Security Considerations

This PR helps improve the locality of inter-package dependencies by avoiding the NPM repository except when publishing.

Scaling Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

Ran unit tests, followed CONTRIBUTING.md to verify that lerna publish correctly replaces workspace: versions with semver when publishing to NPM registry.

Compatibility Considerations

n/a

Upgrade Considerations

n/a

@michaelfig michaelfig requested a review from kriskowal August 17, 2024 20:32
@michaelfig michaelfig force-pushed the mfig-workspace-deps branch from 2db78be to ef16dd7 Compare August 17, 2024 20:32
@michaelfig michaelfig self-assigned this Aug 17, 2024
@michaelfig michaelfig requested a review from turadg August 17, 2024 20:33
@michaelfig michaelfig force-pushed the mfig-workspace-deps branch from ef16dd7 to f6c5c51 Compare August 18, 2024 22:08
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

"typedoc": "^0.25.13",
"typedoc-plugin-markdown": "^3.17.1",
"typedoc": "^0.26.6",
"typedoc-plugin-markdown": "^4.2.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heads up @Jovonni @amessbee since this is part of the docs.agoric.com build pipeline. I don't know if we have CI integration to catch if this breaks anything. I'm approving since it is low impact if it does break temporarily

@turadg turadg mentioned this pull request Aug 19, 2024
@michaelfig michaelfig merged commit 46ca503 into master Aug 19, 2024
17 checks passed
@michaelfig michaelfig deleted the mfig-workspace-deps branch August 19, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants