refactor(ses): Replace Compartment toString property with @@toStringTag #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
commented
Jan 13, 2024
rekmarks
commented
Jan 13, 2024
rekmarks
commented
Jan 13, 2024
kriskowal
requested changes
Jan 17, 2024
rekmarks
force-pushed
the
replace-toString-with-toStringTag
branch
from
64d61d3 to
cf6d268
Compare
Replaces the `Compartment` `toString` function with a `@@toStringTag` string property. This necessitated updating the permit for `%CompartmentPrototype%`, and some related tests. Some adjacent cleanup is also performed.
rekmarks
force-pushed
the
replace-toString-with-toStringTag
branch
from
cf6d268 to
b786521
Compare
kriskowal
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the
CompartmenttoStringfunction with a@@toStringTagstring property. This necessitated updating the permit for%CompartmentPrototype%, and some related tests. Some adjacent cleanup is also performed.Ref: #676