Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default chunk size from 4Kb to 64Kb #1345

Merged
merged 3 commits into from
Dec 5, 2021
Merged

Change default chunk size from 4Kb to 64Kb #1345

merged 3 commits into from
Dec 5, 2021

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Nov 27, 2021

@tomchristie On that issue, you said that "httpx uses 64k read size", but I couldn't find that. Do you mind pointing me out what did you mean?

@Kludex Kludex requested a review from tomchristie November 27, 2021 15:03
@dalf
Copy link

dalf commented Dec 3, 2021

The related issue in httpcore : encode/httpcore#135
In the source code: /~https://github.com/encode/httpcore/blob/4f6d793e440ffeda31d7d064b434ad8083d42634/httpcore/_async/http11.py#L38

Kludex
Kludex commented Dec 3, 2021
View reviewed changes
starlette/responses.py Outdated Show resolved Hide resolved
@Kludex
Copy link
Member Author

Kludex commented Dec 3, 2021

Thanks @dalf ! Much appreciated! 🎉

@Kludex Kludex requested a review from florimondmanca December 3, 2021 17:47
florimondmanca
florimondmanca approved these changes Dec 5, 2021
View reviewed changes
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! That's quite a similar change to the one we made in HTTPX indeed, and for the same reason (improving transfer speed by using larger chunks).

@Kludex
Copy link
Member Author

Kludex commented Dec 5, 2021

Thanks @florimondmanca ! 🎉

@Kludex Kludex merged commit 1d1dcba into encode:master Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florimondmanca florimondmanca florimondmanca approved these changes

@tomchristie tomchristie Awaiting requested review from tomchristie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make FileResponse.chunk_size variable
3 participants
@Kludex @dalf @florimondmanca