Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Remove node/v8 memory64 flags. NFC #23308

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jan 6, 2025

In the latest versions of node and v8 memory64 is not longer experimental.

In the older versions, the experimental memory64 support is not compatible with the latest emscripten-generated memory64 modules (e.g. table64 is completely missing).

@sbc100 sbc100 requested review from kripken and dschuff January 6, 2025 16:56
In the latest versions of node and v8 memory64 is not longer
experimental.

In the older versions, the experimental memory64 support is not
compatible with the latest emscripten-generated memory64 modules (e.g.
table64 is completely missing).
@dschuff
Copy link
Member

dschuff commented Jan 6, 2025

Maybe we should also update the footnote for memory64 on https://webassembly.org/features/
Is there a pre-release build of node that has the feature enabled that we can note? Or one where the flag exposes the up-to-date feature?

@sbc100
Copy link
Collaborator Author

sbc100 commented Jan 6, 2025

Maybe we should also update the footnote for memory64 on https://webassembly.org/features/ Is there a pre-release build of node that has the feature enabled that we can note? Or one where the flag exposes the up-to-date feature?

Sadly not. Only node-canary is supported and it doesn't need/use the flag.

@sbc100 sbc100 enabled auto-merge (squash) January 6, 2025 17:27
@sbc100 sbc100 disabled auto-merge January 6, 2025 18:00
@sbc100 sbc100 merged commit 8af8100 into emscripten-core:main Jan 6, 2025
25 of 29 checks passed
@sbc100 sbc100 deleted the memory64_flags branch January 6, 2025 18:00
@dschuff
Copy link
Member

dschuff commented Jan 6, 2025

I can write something to that effect. Do you have any idea how recent the v8-canary needs to be, or how recent the V8 version needs to be for this to work?

@sbc100
Copy link
Collaborator Author

sbc100 commented Jan 6, 2025

I can write something to that effect. Do you have any idea how recent the v8-canary needs to be, or how recent the V8 version needs to be for this to work?

Not really. The first version of node canary that we tested with full wasm64 support was 24.0.0-v8-canary202411045365c9d9be (#22832).

For v8 I guess we should just go with the first version that supported memory64 un-flagged, which looks like 133: https://chromestatus.com/feature/5070065734516736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants