Reduce memory size used in test_memorygrowth_linear_step. NFC #23301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change the test other than to use lower memory limits. This change works around emscripten-core#22360 which seems to be some kind of bug in node or v8. The result of the bug is that the node process becomes hung in `uv_cond_wait` and never exists at the end of the test. Changing the amount of memory used seems to work around the issue.
dschuff
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change the test other than to use lower memory limits.
This change works around #22360 which seems to be some kind of bug in node or v8. The result of the bug is that the node process becomes hung in
uv_cond_waitand never exists at the end of the test. Changing the amount of memory used seems to work around the issue.