Remove dummy emscripten_set_offscreencanvas_size. NFC #23279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
emscripten_set_offscreencanvas_size
branch
2 times, most recently
from
0783e2d to
5f41454
Compare
kripken
reviewed
Jan 2, 2025
tools/maint/gen_sig_info.py
Outdated
| @@ -172,6 +172,8 @@ def ignore_symbol(s, cxx): | |||
| return True | |||
| if s.startswith('emscripten_gl') or s.startswith('emscripten_alc'): | |||
| return True | |||
| if (s.endswith('_calling_thread') or s.endswith('_main_thread')) and not s.startswith('emscripten_asm_const'): | |||
There was a problem hiding this comment.
Maybe add a comment here? I can't tell what this change is doing.
There was a problem hiding this comment.
I've updated this PR such that this change is no longer needed, so I split the doc changes out into a separate PR.
sbc100
force-pushed
the
emscripten_set_offscreencanvas_size
branch
2 times, most recently
from
6c9e7eb to
34274a3
Compare
kripken
reviewed
Jan 2, 2025
sbc100
force-pushed
the
emscripten_set_offscreencanvas_size
branch
from
34274a3 to
f3bb4b1
Compare
kripken
approved these changes
Jan 2, 2025
This is an internal-only API that is not directly callable by user code. The only place that this function is called is from `system/lib/html5/offscreencanvas.c` as a result of `_emscripten_set_offscreencanvas_size_on_thread`. The only call to `_emscripten_set_offscreencanvas_size_on_thread` is from `setOffscreenCanvasSizeOnTargetThread` which is only ever included when `OFFSCREENCANVAS_SUPPORT` is enabled.
sbc100
force-pushed
the
emscripten_set_offscreencanvas_size
branch
from
f3bb4b1 to
62d9540
Compare
kripken
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an internal-only API that is not directly callable by user code.
The only place that this function is called is from
system/lib/html5/offscreencanvas.cas a result of_emscripten_set_offscreencanvas_size_on_thread.The only call to
_emscripten_set_offscreencanvas_size_on_threadis fromsetOffscreenCanvasSizeOnTargetThreadwhich is only ever included whenOFFSCREENCANVAS_SUPPORTis enabled.