Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nontrapping-fp by default #23007

Merged
merged 13 commits into from
Dec 19, 2024
Merged

Conversation

dschuff
Copy link
Member

@dschuff dschuff commented Nov 25, 2024

Enable nontrapping-fptoint by lowering the browser target requirement.
Once all 3 Safari 15 features have been enabled, I will reset
the requirement correctly.

@dschuff dschuff changed the title [WIP] Enable nontrapping-fp by default Enable nontrapping-fp by default Nov 28, 2024
@dschuff dschuff marked this pull request as ready for review November 28, 2024 00:43
@dschuff
Copy link
Member Author

dschuff commented Nov 28, 2024

Tests are passing; will wait to merge until all 3 are ready.

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I love seeing the code size savings.

@dschuff dschuff enabled auto-merge (squash) December 19, 2024 17:50
@dschuff dschuff merged commit d23a20d into emscripten-core:main Dec 19, 2024
29 checks passed
@sbc100
Copy link
Collaborator

sbc100 commented Dec 19, 2024

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants