Fix create-emotion-styled proxy with react-hot-loader and add appearance: none to search input #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce: none to search input
Closes #539
Codecov Report
|
|
Hi! If React-Hot-Loader would like to access another properties, to be more concrete - cast this component to string - should I just handle these additional keys here? Sorry, it's just not quite clear why one need this Proxy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix create-emotion-styled proxy with react-hot-loader and add appearance: none to search input
Why:
react-hot-loader tries to access some properties on styled and because of the proxy it throws.
How:
Return the actual values when it's those properties
Checklist: