add serde serialize/deserialize derives for public types #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
put them under non-default feature "serde1". exclude some "native" types (such as OwnedFd), that can't be serialized/deserialized properly. Signed-off-by: Eliad Peller <eliad.peller@wiz.io>
|
LGTM on a quick skim, though I'll review more carefully tonight. I'm curious to know more about your use-case, if you don't mind sharing some details. |
|
we simply collect information about some processes, and would like to be able to serialize/deserialize the information easily (e.g. for consumption by other tools) |
|
I spent some more time looking at this, and this continues to look good to me. Since this crate is predominately about parsing structured data, it makes sense to provide serde impls. I can't guarantee that I'll remember to add the derives on future structs, so don't hesitate to get in touch if something is missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
put them under non-default feature "serde1".
exclude some "native" types (such as OwnedFd), that can't
be serialized/deserialized properly.
Signed-off-by: Eliad Peller eliad.peller@wiz.io