Introduce fd_count() in addition to fd() #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prometheus crate uses `fd()` to return the number of open file descriptors. Currently it takes 500ms to count 80k open files in an uncontended case, with this method we can cut this down to just 100ms by not resolving details of every open file descriptor.
|
I like it, thanks! |
bobrik
added a commit
to bobrik/rust-prometheus
that referenced
this pull request
Oct 25, 2020
Picking up eminence/procfs#105. For a service with 80k opten file descriptors this reduces metric collection time from 500ms down to 100ms (no contention).
bobrik
added a commit
to bobrik/rust-prometheus
that referenced
this pull request
Oct 25, 2020
Picking up eminence/procfs#105. For a service with 80k open file descriptors this reduces metric collection time from 500ms down to 100ms (no contention).
bobrik
added a commit
to bobrik/rust-prometheus
that referenced
this pull request
Oct 25, 2020
Picking up eminence/procfs#105. For a service with 80k open file descriptors this reduces metric collection time from 500ms down to 100ms (no contention). Signed-off-by: Ivan Babrou <github@ivan.computer>
|
This has now been published on crates.io as |
bobrik
added a commit
to bobrik/rust-prometheus
that referenced
this pull request
Nov 16, 2020
Picking up eminence/procfs#105. For a service with 80k open file descriptors this reduces metric collection time from 500ms down to 100ms (no contention). Signed-off-by: Ivan Babrou <github@ivan.computer>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus crate uses
fd()to return the number of open file descriptors. Currently it takes 500ms to count 80k open files in an uncontended case, with this method we can cut this down to just 100ms by not resolving details of every open file descriptor.See: /~https://github.com/tikv/rust-prometheus/blob/512e8ed44c0fbbcef/src/process_collector.rs#L134-L137