egui_glow: Add function to set the texture filter #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a `set_scale_filter` method to the `glow` painter so that textures can be set to scale using nearest-neighbour scaling rather than linear. This is useful for pixel art. I wasn't entirely sure what kind of API you want for this kind of change so I went with what seemed least intrusive, I don't mind doing something more holistic if this isn't what you had in mind.
emilk
requested changes
Jan 5, 2022
egui_glow/src/painter.rs
Outdated
| @@ -35,6 +35,7 @@ pub struct Painter { | |||
| is_embedded: bool, | |||
| vertex_array: crate::misc_util::VAO, | |||
| srgb_support: bool, | |||
| scale_filter: u32, | |||
There was a problem hiding this comment.
Suggested change
| scale_filter: u32, | |
| /// The filter used for subsequent textures. | |
| scale_filter: ScaleFilter, |
|
Done, changed to |
justinj
force-pushed
the
glow-scale-filter
branch
from
f06845d to
dd6dc81
Compare
emilk
reviewed
Jan 6, 2022
egui_glow/src/painter.rs
Outdated
| @@ -35,6 +35,8 @@ pub struct Painter { | |||
| is_embedded: bool, | |||
| vertex_array: crate::misc_util::VAO, | |||
| srgb_support: bool, | |||
| /// The filter used for subsequent textures. | |||
| texture_filter: u32, | |||
There was a problem hiding this comment.
wouldn't it be nicer to use TextureFilter here and defer the call to glow_code? It would keep the code typesafe for longer.
Suggested change
| texture_filter: u32, | |
| texture_filter: TextureFilter, |
There was a problem hiding this comment.
Sure, seems reasonable to me!
emilk
requested changes
Jan 6, 2022
emilk
approved these changes
Jan 6, 2022
emilk
changed the title
glow backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a
set_scale_filtermethod to theglowpainter so thattextures can be set to scale using nearest-neighbour scaling rather than
linear. This is useful for pixel art.
I wasn't entirely sure what kind of API you want for this kind of change so I
went with what seemed least intrusive, I don't mind doing something more
holistic if this isn't what you had in mind.
Linear:
Nearest:
