Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make project PEP 561 compliant #193

Merged
merged 2 commits into from
Dec 8, 2023
Merged

build: make project PEP 561 compliant #193

merged 2 commits into from
Dec 8, 2023

Conversation

Rahuljagwani
Copy link
Contributor

Description

Fixes #187

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation (or documentation does not need to be updated)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not reduced the existing code coverage

@Rahuljagwani Rahuljagwani requested a review from uniqueg December 8, 2023 13:35
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c89ba8) 100.00% compared to head (1f4c298) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #193   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          984       984           
=========================================
  Hits           984       984           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Wrap lines according to style used in the repository
@uniqueg
Copy link
Member

uniqueg commented Dec 8, 2023

Thanks a lot @Rahuljagwani, much appreciated 🚀 And apologies for the complications.

I have wrapped the package_data lines according to the style we use in our organization. Once the tests have passed, I will merge this.

@uniqueg uniqueg merged commit 948c031 into dev Dec 8, 2023
15 checks passed
@uniqueg uniqueg deleted the pep561 branch December 8, 2023 13:48
@uniqueg
Copy link
Member

uniqueg commented Dec 8, 2023

Just in case you are interested in contributing regularly to our organization, please contact me at email address listed in my profile so that I can send you onboarding instructions :)

@Rahuljagwani
Copy link
Contributor Author

Just in case you are interested in contributing regularly to our organization, please contact me at email address listed in my profile so that I can send you onboarding instructions :)

Sure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: make project PEP 561 compliant
2 participants