Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use pathlib.Path for file paths #134

Merged
merged 5 commits into from
Jun 25, 2022
Merged

refactor: use pathlib.Path for file paths #134

merged 5 commits into from
Jun 25, 2022

Conversation

uniqueg
Copy link
Member

@uniqueg uniqueg commented Jun 25, 2022

Description

  • use pathlib.Path for passing file paths and replacing operations from the os module
  • bump version to v0.9.0

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation (or documentation does not need to be updated)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not reduced the existing code coverage

@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #134 (c6108e2) into dev (54c6929) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev      #134   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          694       695    +1     
=========================================
+ Hits           694       695    +1     
Impacted Files Coverage Δ
foca/__init__.py 100.00% <100.00%> (ø)
foca/config/config_parser.py 100.00% <100.00%> (ø)
foca/foca.py 100.00% <100.00%> (ø)
foca/models/config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54c6929...c6108e2. Read the comment docs.

@uniqueg uniqueg merged commit 8676b93 into dev Jun 25, 2022
@uniqueg uniqueg deleted the use_pathlib branch June 25, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant