Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate custom config #128

Merged
merged 2 commits into from
Jun 22, 2022
Merged

feat: validate custom config #128

merged 2 commits into from
Jun 22, 2022

Conversation

uniqueg
Copy link
Member

@uniqueg uniqueg commented Jun 22, 2022

Description

  • users can now provide a pydantic model class that is used to set custom configuration parameters via parameter custom_config_model to foca()
  • parameters in section custom of the app configuration are used to populate/override the custom configuration, if available

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not reduced the existing code coverage

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #128 (10c74f3) into dev (944dc1e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev      #128   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          670       689   +19     
=========================================
+ Hits           670       689   +19     
Impacted Files Coverage Δ
foca/models/config.py 100.00% <ø> (ø)
foca/config/config_parser.py 100.00% <100.00%> (ø)
foca/foca.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 944dc1e...10c74f3. Read the comment docs.

@uniqueg uniqueg merged commit 12edef3 into dev Jun 22, 2022
@uniqueg uniqueg deleted the validate_custom_config branch June 22, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant