[BUGFIX] Invalidate sitemaps cache when site config changes #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliashaeussler
force-pushed
the
fix/invalidate-caches
branch
from
5fa858e to
ad3bd1b
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
============================================
+ Coverage 92.46% 92.54% +0.08%
- Complexity 404 409 +5
============================================
Files 50 51 +1
Lines 1327 1342 +15
============================================
+ Hits 1227 1242 +15
Misses 100 100
☔ View full report in Codecov by Sentry. |
|
Code Climate has analyzed commit 74414ec and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 92.5% (0.0% change). View more on Code Climate. |
eliashaeussler
force-pushed
the
fix/invalidate-caches
branch
from
ad3bd1b to
00eea0b
Compare
eliashaeussler
force-pushed
the
fix/invalidate-caches
branch
from
00eea0b to
74414ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an event listener to remove a sitemaps cache entry if the associated site's configuration is changed. This effectively triggers a new site resolving which takes the modified site properties into account.