[TASK] Improve sitemaps cache handling #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliashaeussler
force-pushed
the
task/cache
branch
from
445e1b1 to
399c4b9
Compare
eliashaeussler
force-pushed
the
task/cache
branch
from
399c4b9 to
0f0f5bb
Compare
|
Code Climate has analyzed commit 0f0f5bb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 92.4% (0.0% change). View more on Code Climate. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #434 +/- ##
============================================
+ Coverage 92.45% 92.46% +0.01%
Complexity 404 404
============================================
Files 50 50
Lines 1325 1327 +2
============================================
+ Hits 1225 1227 +2
Misses 100 100
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves handling of sitemaps cache by using a separate cache entry for each site. This way, the complete Caching API of TYPO3 can be used to modify cache entries, instead of re-implementing several filesystem-based parts (reading, writing, manipulating) on our own.