Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Provide custom log table #377

Merged
merged 7 commits into from
Aug 26, 2023
Merged

[FEATURE] Provide custom log table #377

merged 7 commits into from
Aug 26, 2023

Conversation

eliashaeussler
Copy link
Owner

This PR adds a custom log table tx_warming_domain_model_log. It can be used in combination with the provided DatabaseWriter to log crawling results.

@eliashaeussler eliashaeussler added the enhancement New feature or request label Aug 11, 2023
@eliashaeussler eliashaeussler self-assigned this Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 68.57% and project coverage change: -2.85% ⚠️

Comparison is base (69cf249) 95.29% compared to head (8594f59) 92.45%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #377      +/-   ##
============================================
- Coverage     95.29%   92.45%   -2.85%     
- Complexity      357      404      +47     
============================================
  Files            44       50       +6     
  Lines          1190     1325     +135     
============================================
+ Hits           1134     1225      +91     
- Misses           56      100      +44     
Files Changed Coverage Δ
Classes/Crawler/ConcurrentUserAgentCrawler.php 100.00% <ø> (ø)
Classes/Crawler/OutputtingUserAgentCrawler.php 100.00% <ø> (ø)
Classes/Domain/Model/Log.php 0.00% <0.00%> (ø)
...asses/Form/FormDataProvider/SimulateLogPageRow.php 81.81% <81.81%> (ø)
...es/Backend/ToolbarItems/CacheWarmupToolbarItem.php 96.29% <100.00%> (+0.06%) ⬆️
Classes/Command/WarmupCommand.php 100.00% <100.00%> (ø)
Classes/Crawler/LoggingCrawlerTrait.php 86.66% <100.00%> (+11.66%) ⬆️
Classes/Domain/Type/StateType.php 100.00% <100.00%> (ø)
Classes/Enums/WarmupState.php 100.00% <100.00%> (ø)
Classes/Log/Writer/DatabaseWriter.php 100.00% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeclimate
Copy link

codeclimate bot commented Aug 11, 2023

Code Climate has analyzed commit 8594f59 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 68.5% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.4% (-2.7% change).

View more on Code Climate.

@eliashaeussler eliashaeussler merged commit d29c837 into main Aug 26, 2023
@eliashaeussler eliashaeussler deleted the feature/log-table branch August 26, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant