Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Extract warmup request id from query parameters #376

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

eliashaeussler
Copy link
Owner

@eliashaeussler eliashaeussler commented Aug 11, 2023

This PR fixes the WarmupRequest value object to be able to actually map the request id from request query parameters to the object during hydration.

@eliashaeussler eliashaeussler added the bug Something isn't working label Aug 11, 2023
@eliashaeussler eliashaeussler self-assigned this Aug 11, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 11, 2023

Code Climate has analyzed commit a5b4245 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.2% (0.0% change).

View more on Code Climate.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d1d248c) 95.29% compared to head (a5b4245) 95.29%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #376   +/-   ##
=========================================
  Coverage     95.29%   95.29%           
  Complexity      357      357           
=========================================
  Files            44       44           
  Lines          1190     1190           
=========================================
  Hits           1134     1134           
  Misses           56       56           
Files Changed Coverage Δ
Classes/ValueObject/Request/WarmupRequest.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eliashaeussler eliashaeussler merged commit 95c974c into main Aug 11, 2023
@eliashaeussler eliashaeussler deleted the fix/request-id branch August 11, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant