[!!!][FEATURE] Support multiple sitemaps to be located #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliashaeussler
added
enhancement
12 tasks
eliashaeussler
force-pushed
the
feature/multiple-sitemaps
branch
from
bb86699 to
a613d03
Compare
|
Code Climate has analyzed commit 1f26c43 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 98.7% (50% is the threshold). This pull request will bring the total coverage in the repository to 96.6% (0.0% change). View more on Code Climate. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
============================================
- Coverage 96.68% 96.66% -0.03%
- Complexity 333 340 +7
============================================
Files 41 41
Lines 1116 1139 +23
============================================
+ Hits 1079 1101 +22
- Misses 37 38 +1
☔ View full report in Codecov by Sentry. |
eliashaeussler
force-pushed
the
feature/multiple-sitemaps
branch
from
a613d03 to
1f26c43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way how sitemaps are located in order to support multiple sitemaps being returned by sitemap providers. This is especially useful when using a
robots.txtfile with multipleSitemapdeclarations. Prior to this change, only the first sitemap was respected. With this PR, all declared sitemaps are now returned.EliasHaeussler\Typo3Warming\Sitemap\Provider\Provider::get().Related: #199