[BUGFIX] Properly check for hidden pages in AccessUtility
#323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit ee8c402 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 72.8% (0.0% change). View more on Code Climate. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
=========================================
Coverage 72.80% 72.80%
+ Complexity 333 332 -1
=========================================
Files 41 41
Lines 1114 1114
=========================================
Hits 811 811
Misses 303 303
☔ View full report in Codecov by Sentry. |
eliashaeussler
force-pushed
the
fix/exclude-hidden-pages
branch
from
51baf12 to
ce44649
Compare
eliashaeussler
force-pushed
the
fix/exclude-hidden-pages
branch
from
ce44649 to
ee8c402
Compare
eliashaeussler
changed the title
AccessUtility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hardens the page permission check for pages in
AccessUtility. If any page is hidden, even users with admin privileges can no longer warmup those pages.