Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Pass scalar values to sub-command #241

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

eliashaeussler
Copy link
Owner

In order to properly mimic the behavior of the upstream cache-warmup command, sub-command input parameters are now always passed as scalar values. In addition, the input option limit is now properly resolved to a positive integer.

Resolves: #239

@eliashaeussler eliashaeussler added the bug Something isn't working label Apr 23, 2023
@eliashaeussler eliashaeussler self-assigned this Apr 23, 2023
@codeclimate
Copy link

codeclimate bot commented Apr 23, 2023

Code Climate has analyzed commit f6a8760 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 21.5% (0.0% change).

View more on Code Climate.

@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (f54e9b2) 21.59% compared to head (f6a8760) 21.52%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #241      +/-   ##
============================================
- Coverage     21.59%   21.52%   -0.08%     
  Complexity      296      296              
============================================
  Files            27       27              
  Lines           917      920       +3     
============================================
  Hits            198      198              
- Misses          719      722       +3     
Impacted Files Coverage Δ
Classes/Command/WarmupCommand.php 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eliashaeussler eliashaeussler merged commit c7252fc into main Apr 23, 2023
@eliashaeussler eliashaeussler deleted the fix/sub-command-input branch April 23, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Argument 1 passed to GuzzleHttp\Psr7\Uri::__construct() must be of the type string, object given
1 participant