Adw.PreferencesWindow #1245
Merged
Adw.PreferencesWindow #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-mkh
reviewed
Mar 21, 2023
BTW .boxed-list is in GTK now and inspector is using it, so it's not libadwaita-specific anymore. The action rows etc still are tho. |
|
@Exalm if you wanted to look at this and point out any obvious mistakes that would be appreciated :) It's only meant to make Adw.PreferencesWindow usable, so it doesn't address anything outside of that and I'm aware that there's some missing stuff like focus styles, error states, etc in the entry row |
alice-mkh
reviewed
Mar 22, 2023
alice-mkh
reviewed
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds styles for Adw.PreferencesWindow as used in Epiphany. It isn't totally perfect and doesn't cover all the cases of Adwaita, but it makes Epiphany usable at least