Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init: add ensure type #632

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Init: add ensure type #632

merged 2 commits into from
Feb 22, 2023

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Feb 21, 2023 •
edited
Loading

Does the least to give a way for Adwaita to detect that Granite has been initialized so that it can disable styles i.e. for Epiphany

@danirabbit danirabbit marked this pull request as ready for review February 21, 2023 18:53
@danirabbit danirabbit requested a review from a team February 21, 2023 18:53
alice-mkh
alice-mkh approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@alice-mkh alice-mkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@danirabbit danirabbit requested a review from alice-mkh February 21, 2023 19:00
@alice-mkh
Copy link
Contributor

Works fine on libadwaita side.

tintou
tintou approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@tintou tintou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One might revisit this init function to use a GLib.Once but that's just a nit

@danirabbit danirabbit merged commit 2fa2311 into main Feb 22, 2023
@danirabbit danirabbit deleted the ensure-type branch February 22, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tintou tintou tintou approved these changes

@alice-mkh alice-mkh Awaiting requested review from alice-mkh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danirabbit @alice-mkh @tintou