Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make room tagging flux-y #6096

Merged
merged 8 commits into from
Feb 13, 2018
Merged

Make room tagging flux-y #6096

merged 8 commits into from
Feb 13, 2018

Conversation

lukebarnard1
Copy link
Contributor

@lukebarnard1 lukebarnard1 commented Feb 6, 2018

  • Moves RoomTileContextMenu over to new async action to set room tags.
  • Adds a DragDropContext that handles drag and drop for TagPanel and RoomList. This is to
    allow the future feature of dragging between the two components.
  • Prevents RoomTiles from being dragged elsewhere for the time being.

See matrix-org/matrix-react-sdk#1719

lukebarnard1 and others added 7 commits January 25, 2018 22:30
that handles drag and drop for TagPanel and RoomList. This is to
allow the future feature of dragging between the two components.
NB: fixUndefinedOrdering was removed completely because it was
code dealing with legacy favourites.

see matrix-org/matrix-react-sdk@9b0df191
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

import VectorConferenceHandler from '../../VectorConferenceHandler';

import SettingsStore from "matrix-react-sdk/lib/settings/SettingsStore";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: quotes

@dbkr dbkr assigned lukebarnard1 and unassigned dbkr Feb 12, 2018
@dbkr dbkr merged commit e671472 into develop Feb 13, 2018
@t3chguy t3chguy deleted the luke/room-list-flux branch May 12, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants