Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable react-compiler eslint to spot antipatterns #28652

Merged
merged 16 commits into from
Jan 16, 2025
Merged

Enable react-compiler eslint to spot antipatterns #28652

merged 16 commits into from
Jan 16, 2025

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Dec 5, 2024 •
edited
Loading

Requires #28651

@t3chguy
Switch to React18 useId
b61a222 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Enable react-compiler eslint
c8c5ef5 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Fix an easy one
e730074 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Disable in tests
eb1a09a 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Merge branch 't3chguy/useId' of /~https://github.com/vector-im/element-web
6c2334c 
 into t3chguy/react-compiler-eslint
@t3chguy
Fix usage of useRef as memoization
9443426 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Fix mutation of external values in hooks
b597abf 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Make React compiler happy about some frankly non-issues
72f1556 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy added the T-Task Tasks for the team like planning label Dec 5, 2024
@t3chguy t3chguy self-assigned this Dec 5, 2024
@t3chguy
Fix MapMock
c3f3c93 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Iterate
6946b90 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Merge branch 'develop' of /~https://github.com/vector-im/element-web in…
9ef3ea6 
…to t3chguy/react-compiler-eslint

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

# Conflicts:
#	yarn.lock
@t3chguy
Iterate
24d4ecf 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Merge branch 'develop' of /~https://github.com/vector-im/element-web in…
380f5bb 
…to t3chguy/react-compiler-eslint

# Conflicts:
#	src/components/views/settings/ThemeChoicePanel.tsx
#	src/hooks/useUserOnboardingContext.ts
@t3chguy
Iterate
ba71ce1 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy marked this pull request as ready for review January 16, 2025 10:24
@t3chguy t3chguy requested review from a team as code owners January 16, 2025 10:24
@t3chguy t3chguy requested review from dbkr and MidhunSureshR January 16, 2025 10:24
dbkr
dbkr approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a useful bunch of catches.

@t3chguy
Revert MemberListViewModel.tsx changes and disable linter per line
a052509 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy enabled auto-merge January 16, 2025 11:46
@MidhunSureshR
Make viewmodel compatible with react-compiler linter
83ef292 
- Remove searchQuery ref/state and instead pass this query to the
  loadMember function.
- Now we no longer need a separate search function
@t3chguy t3chguy added this pull request to the merge queue Jan 16, 2025
Merged via the queue into develop with commit ef1597f Jan 16, 2025
31 checks passed
@t3chguy t3chguy deleted the t3chguy/react-compiler-eslint branch January 16, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t3chguy @dbkr @MidhunSureshR