More app-loading tests #1938
Merged
More app-loading tests #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. fix the 'Clean load' tests which had been broken by matrix-org/matrix-react-sdk#399: make sure we clear localStorage between tests. 2. Test the session rehydration properly by setting the localStorage rather than setting up the MatrixClientPeg before loading the app. 3. Add some tests for the auto-guest-registration flows.
|
lgtm, presumably tests are failing intentionally because the fix is in the react sdk pr I just merged? |
|
yup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move rehydration of MatrixClients from MatrixClientPeg to SessionLoader matrix-org/matrix-react-sdk#399: make sure we clear
localStorage between tests.
than setting up the MatrixClientPeg before loading the app.