Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notifications warning layout #1907

Merged
merged 1 commit into from
Aug 1, 2016

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Aug 1, 2016

For some reason, Chrome doesn't seem to make the central div in the
notifications warning wide enough, so it ends up wrapping. Fix this by making
the central div expand across the available space, instead of letting the
container for the close button do it.

Fixes #1687

For some reason, Chrome doesn't seem to make the central div in the
notifications warning wide enough, so it ends up wrapping. Fix this by making
the central div expand across the available space, instead of letting the
container for the close button do it.

Fixes #1687
@ara4n
Copy link
Member

ara4n commented Aug 1, 2016

lgtm. i vaguely remember that Safari's -webkit-flex: 1 uses different defaults from the standard flex: 1 so may have to be spelt out as -webkit-flex: 1 1 auto or similar... however, i suggest only adding this if it's seen as a bug.

@ara4n ara4n removed their assignment Aug 1, 2016
@richvdh richvdh merged commit 2123fec into develop Aug 1, 2016
@richvdh richvdh deleted the rav/fix_notification_warning_display branch August 1, 2016 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

formatting of notifications banner is broken
2 participants