Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/aris/threads UI enhancements #5614

Merged
merged 15 commits into from
Apr 5, 2022

Conversation

ariskotsomitopoulos
Copy link
Contributor

@ariskotsomitopoulos ariskotsomitopoulos commented Mar 23, 2022

This PR contains multiple UI improvements regarding design implementation review

Closes #5593

@github-actions
Copy link

github-actions bot commented Mar 23, 2022

Unit Test Results

110 files  ±0  110 suites  ±0   1m 23s ⏱️ -12s
195 tests ±0  195 ✔️ ±0  0 💤 ±0  0 ±0 
650 runs  ±0  650 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 6e06aed. ± Comparison against base commit 3aac59a.

♻️ This comment has been updated with latest results.

@ariskotsomitopoulos ariskotsomitopoulos requested review from a team and ahmed-radhouane and removed request for a team March 30, 2022 08:51
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could be nice to have some screenshots before/after for such PR (for next time).

@bmarty bmarty removed the request for review from ahmed-radhouane April 5, 2022 07:59
@ouchadam ouchadam added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Apr 5, 2022
# Conflicts:
#	vector/src/main/res/menu/menu_timeline.xml
@ariskotsomitopoulos
Copy link
Contributor Author

LGTM, could be nice to have some screenshots before/after for such PR (for next time).

True, I skipped that while the changes where so tiny and so many, like changing 3dp to 4dp etc. Next time I will try to include that in the PR desc, or screenshot if there is a visible change

@bmarty bmarty merged commit ca418af into develop Apr 5, 2022
@bmarty bmarty deleted the feature/aris/threads_ui_enhancements branch April 5, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Threads Beta — Design implementation review
3 participants