Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: depend on pulseaudio, not libpulse0 #35

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Conversation

malept
Copy link
Member

@malept malept commented Jun 20, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Electron has a dependency on libasound2. If you need Pulseaudio support, you'll need pulseaudio anyway. This has the side benefit of also requiring libasound2.

Electron has a dependency on libasound2. If you need pulseaudio support,
you'll need pulseaudio anyway. This has the side benefit of also
requiring libasound2.
@malept malept merged commit f6eed8e into master Jun 20, 2019
@malept malept deleted the fix-pulseaudio-dep branch June 20, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant