Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow usage of .cjs, .mjs, and type=module custom publishers #8868

Merged
merged 22 commits into from
Feb 21, 2025

Conversation

mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Feb 17, 2025

Resolves: #8862

Adds AsyncEventEmitter:

  • allows listeners to be queued as Promises and resolved during emit
  • event name type-safety
  • Consolidates a majority of resolveFunction for user hooks to the beginning of the packager build process so users can detect errors early if import is incorrect

Adds unit test to cover all core user-provided hooks

Copy link

changeset-bot bot commented Feb 17, 2025

🦋 Changeset detected

Latest commit: 7bae4e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmaietta mmaietta marked this pull request as ready for review February 17, 2025 02:12
@mmaietta mmaietta requested a review from beyondkmp February 18, 2025 00:08
beyondkmp
beyondkmp previously approved these changes Feb 21, 2025
@mmaietta mmaietta merged commit 48c9f88 into master Feb 21, 2025
17 checks passed
@mmaietta mmaietta deleted the feat/esm-publisher branch February 21, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow custom publisher with .cjs Extension
2 participants