Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build --target dir doesn't work #531

Closed
dfabulich opened this issue Jun 22, 2016 · 1 comment · May be fixed by qcif/data-curator#563
Closed

build --target dir doesn't work #531

dfabulich opened this issue Jun 22, 2016 · 1 comment · May be fixed by qcif/data-curator#563

Comments

@dfabulich
Copy link
Contributor

/~https://github.com/electron-userland/electron-builder/blob/master/README.md

The README says to install a pack script like this:

"scripts": {
  "postinstall": "install-app-deps",
  "pack": "build --target dir",
  "dist": "build"
}

And then you can run npm run dist (to package in a distributable format (e.g. dmg, windows installer, deb package)) or npm run pack.

But the build command doesn't accept a target parameter, so if you actually try to npm run pack, you just get an error message, Unknown argument: target

dfabulich added a commit to dfabulich/electron-builder that referenced this issue Jun 22, 2016
@develar
Copy link
Member

develar commented Jun 22, 2016

I think, we should add --dir to build dir target for current platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants