Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure build resources directory #184

Closed
develar opened this issue Feb 26, 2016 · 10 comments · May be fixed by qcif/data-curator#563
Closed

Configure build resources directory #184

develar opened this issue Feb 26, 2016 · 10 comments · May be fixed by qcif/data-curator#563
Assignees
Labels

Comments

@develar
Copy link
Member

develar commented Feb 26, 2016

Proposal:

Use directories.buildResources key in the development package.json.

Default value: build
Path relative to the root of project (i.e. development package.json).

@develar develar self-assigned this Feb 26, 2016
@uggrock
Copy link

uggrock commented Feb 26, 2016

This will be great!

@develar
Copy link
Member Author

develar commented Feb 26, 2016

@uggrock Could you please specify your desired value (name of your build folder)? May be we can just try to use it by default (i.e. if it is named assets, it is reasonable to just try to find such folder in the project dir automatically by default).

@demetris-manikas
Copy link
Contributor

Why not just follow the path given? e.g: "background": "RELATIVE_DIR/MY_BACKGROUND_NAME.jpg" ?

@develar
Copy link
Member Author

develar commented Feb 27, 2016

@demetris-manikas

As user, I don't want to specify all of required paths.
As user, I want to build my app in distributable format for all possible platforms. Don't learn all required tools to do it.

electron-builder does it for you. You need just follow convention.

So, I think, it is better for user just follow some convention. And tool will do of the rest.

@demetris-manikas
Copy link
Contributor

@develar I am not saying that defaults should not exist. But that a good tool allows the user to override defaults. For me it's not a good thing for a tool to enforce the layout of an application in anyway.
e.g. Say that an app uses the same icon that is being used for the installer. The tool enforces the user to duplicate the resource leading to another thing to remember to do when changing the icon.

@develar
Copy link
Member Author

develar commented Feb 27, 2016

@demetris-manikas Understand. It will be implemented. Not recommended, but not a good thing for a tool to enforce the layout of an application.

@develar
Copy link
Member Author

develar commented Feb 28, 2016

@demetris-manikas I have realised that you request is already implemented – see /~https://github.com/loopline-systems/electron-builder#distributable-format-configuration (just specify own background). If it doesn't work, please file an issue.

@demetris-manikas
Copy link
Contributor

It was not my request but anyway I 'll try it first thing in the morning...

develar added a commit to develar/electron-builder that referenced this issue Mar 2, 2016
Tests refactored to simplify new test addition
ESLint added to check test code

Closes electron-userland#184
develar added a commit to develar/electron-builder that referenced this issue Mar 2, 2016
Tests refactored to simplify new test addition
ESLint added to check test code

Closes electron-userland#184
@jayalfredprufrock
Copy link

I've been trying to specify my own location for the OSX icon file as detailed in the docs and it doesn't seem to be working. I know it's finding the icon because if I alter the path to something bogus it throws an error. Specifying the background image DOES work though. Oddly enough, when I place the icon.icns file and background.png file in the "build" directory and rely on the defaults, the icon loads properly but not the background. I've had to use a combination of both methods to get everything to work.

develar added a commit to develar/electron-builder that referenced this issue Mar 3, 2016
Tests refactored to simplify new test addition
ESLint added to check test code
Remove old electron version from cache to clear cache

Closes electron-userland#184
develar added a commit to develar/electron-builder that referenced this issue Mar 3, 2016
Tests refactored to simplify new test addition
ESLint added to check test code
Remove old electron version from cache to clear cache

Closes electron-userland#184
develar added a commit to develar/electron-builder that referenced this issue Mar 3, 2016
Tests refactored to simplify new test addition
ESLint added to check test code

Closes electron-userland#184
develar added a commit to develar/electron-builder that referenced this issue Mar 3, 2016
Tests refactored to simplify new test addition
ESLint added to check test code

Closes electron-userland#184
develar added a commit to develar/electron-builder that referenced this issue Mar 3, 2016
Tests refactored to simplify new test addition
ESLint added to check test code

Closes electron-userland#184
develar added a commit to develar/electron-builder that referenced this issue Mar 3, 2016
Tests refactored to simplify new test addition
ESLint added to check test code

Closes electron-userland#184
develar added a commit to develar/electron-builder that referenced this issue Mar 3, 2016
Tests refactored to simplify new test addition
ESLint added to check test code

Closes electron-userland#184
develar added a commit to develar/electron-builder that referenced this issue Mar 3, 2016
Tests refactored to simplify new test addition
ESLint added to check test code

Closes electron-userland#184, electron-userland#196
develar added a commit that referenced this issue Mar 3, 2016
fix: Configure build resources directory #184
@develar
Copy link
Member Author

develar commented Mar 3, 2016

@jayalfredprufrock Reported as #197.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants