-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure build resources directory #184
Comments
This will be great! |
@uggrock Could you please specify your desired value (name of your |
Why not just follow the path given? e.g: "background": "RELATIVE_DIR/MY_BACKGROUND_NAME.jpg" ? |
As user, I don't want to specify all of required paths.
So, I think, it is better for user just follow some convention. And tool will do of the rest. |
@develar I am not saying that defaults should not exist. But that a good tool allows the user to override defaults. For me it's not a good thing for a tool to enforce the layout of an application in anyway. |
@demetris-manikas Understand. It will be implemented. Not recommended, but |
@demetris-manikas I have realised that you request is already implemented – see /~https://github.com/loopline-systems/electron-builder#distributable-format-configuration (just specify own |
It was not my request but anyway I 'll try it first thing in the morning... |
Tests refactored to simplify new test addition ESLint added to check test code Closes electron-userland#184
Tests refactored to simplify new test addition ESLint added to check test code Closes electron-userland#184
I've been trying to specify my own location for the OSX icon file as detailed in the docs and it doesn't seem to be working. I know it's finding the icon because if I alter the path to something bogus it throws an error. Specifying the background image DOES work though. Oddly enough, when I place the icon.icns file and background.png file in the "build" directory and rely on the defaults, the icon loads properly but not the background. I've had to use a combination of both methods to get everything to work. |
Tests refactored to simplify new test addition ESLint added to check test code Remove old electron version from cache to clear cache Closes electron-userland#184
Tests refactored to simplify new test addition ESLint added to check test code Remove old electron version from cache to clear cache Closes electron-userland#184
Tests refactored to simplify new test addition ESLint added to check test code Closes electron-userland#184
Tests refactored to simplify new test addition ESLint added to check test code Closes electron-userland#184
Tests refactored to simplify new test addition ESLint added to check test code Closes electron-userland#184
Tests refactored to simplify new test addition ESLint added to check test code Closes electron-userland#184
Tests refactored to simplify new test addition ESLint added to check test code Closes electron-userland#184
Tests refactored to simplify new test addition ESLint added to check test code Closes electron-userland#184, electron-userland#196
fix: Configure build resources directory #184
@jayalfredprufrock Reported as #197. |
Proposal:
Use directories.
buildResources
key in the development package.json.Default value:
build
Path relative to the root of project (i.e. development package.json).
The text was updated successfully, but these errors were encountered: