Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Document the new rule execution status filter #3570

Merged
merged 4 commits into from
Jul 18, 2023
Merged

[DOCS] Document the new rule execution status filter #3570

merged 4 commits into from
Jul 18, 2023

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Jul 14, 2023 •
edited by natasha-moore-elastic
Loading

Fixes #3486

Previews:

  • Manage detection rules: Made the following changes:
    • Refreshed screenshot of the Rules table
    • Added Last response filter to the list of filters under Sort and filter the rules list
    • Added a sentence on the Last response filter under Check the current status of rules
  • Monitor and troubleshoot rule executions: Refreshed screenshot of Rule Monitoring tab.

@nastasha-solomon nastasha-solomon added Team: Detections/Response Detections and Response Feature: Rules v8.9.0 Priority: Medium Issues that have relevance, but aren't urgent Effort: Small Issues that can be resolved quickly labels Jul 14, 2023
@nastasha-solomon nastasha-solomon self-assigned this Jul 14, 2023
@github-actions
Copy link

Documentation previews:

@nastasha-solomon
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

@natasha-moore-elastic natasha-moore-elastic marked this pull request as ready for review July 17, 2023 15:39
@natasha-moore-elastic natasha-moore-elastic requested a review from a team July 17, 2023 15:39
@joepeeples joepeeples self-requested a review July 17, 2023 16:03
joepeeples
joepeeples reviewed Jul 18, 2023
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick touch-up on the Rule Monitoring screenshot, otherwise LGTM!

docs/detections/images/monitor-table.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the mouse pointer got captured on this one -- near the top above Add Elastic rules.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I thought I deleted that. I'll fix it now - thanks!

Copy link
Contributor

@joepeeples joepeeples Jul 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem! Once that image is fixed, this is probably good to merge -- we've had three writers working on/reviewing this, and it's such a small change that we probably don't need a tech/dev/product review.

@nastasha-solomon nastasha-solomon merged commit 8ee7de3 into main Jul 18, 2023
mergify bot pushed a commit that referenced this pull request Jul 18, 2023
@nastasha-solomon @mergify
[DOCS] Document the new rule execution status filter (#3570)
b079766 
Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
(cherry picked from commit 8ee7de3)
@mergify mergify bot mentioned this pull request Jul 18, 2023
Merged
nastasha-solomon added a commit that referenced this pull request Jul 18, 2023
@mergify @natasha-moore-elastic @nastasha-solomon
[8.9] [DOCS] Document the new rule execution status filter (backport #…
0c76613 
…3570) (#3580)

Co-authored-by: natasha-moore-elastic <natasha.moore@elastic.co>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
@nastasha-solomon nastasha-solomon mentioned this pull request Jul 21, 2023
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepeeples joepeeples joepeeples left review comments

Assignees

@nastasha-solomon nastasha-solomon

@natasha-moore-elastic natasha-moore-elastic

Labels
Effort: Small Issues that can be resolved quickly Feature: Rules Priority: Medium Issues that have relevance, but aren't urgent Team: Detections/Response Detections and Response v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] Document the new rule execution status filter
3 participants
@nastasha-solomon @joepeeples @natasha-moore-elastic