-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prebuilt detection rules: new UI for installing and upgrading #3552
Conversation
- "Installed Rules" tab - "Add Elastic rules" button
Documentation previews: |
outdated instructions
@elasticmachine run elasticsearch-ci/docs |
Addresses #3525
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic documentation update @joepeeples! 🎉
I did leave a few comments though, some of them are minor.
cc @xcrzx @jpdjere in case you'd like to take a look as well.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea breaking out the instructions for working with prebuilt rules. I left a handful of suggestions - hopefully they're helpful!
1st round Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Georgii Gorbachev <banderror@gmail.com>
Renamed file for good measure (though not necessary)
Thanks Joe! New docs look great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't too nitpicky with comments in the interest of time, but this was a really great write-up, @joepeeples! I see Ksenia and Georgii left some feedback too. Once all that's incorporated, this will be good to go!
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @joepeeples for addressing all the comments! Looks great!
* Rename tab, button - "Installed Rules" tab - "Add Elastic rules" button * Fix docs bug: duplicating prebuilt rules outdated instructions * Add Asciidoc frontmatter * Update "Install and enable" section * Add "Update rules" section * Break out prebuilt rules topic, add images * Add frontmatter, li'l cleanup * Fix x-docs link * Add section on tag categories Addresses #3525 * Revise description frontmatter * Update image, add use case * Update ref in Container Workload Protection * Apply suggestions from reviews 1st round Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Georgii Gorbachev <banderror@gmail.com> * Explain cost of duplicating rules * Rename page Renamed file for good measure (though not necessary) * Tighten up images * Apply feedback from Kseniia * Remove outdated video * Revise & move download section * Apply suggestions from Janeen's review Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * Remove download section, update xref --------- Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Georgii Gorbachev <banderror@gmail.com> Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit 42a3e6c)
…#3621) * Rename tab, button - "Installed Rules" tab - "Add Elastic rules" button * Fix docs bug: duplicating prebuilt rules outdated instructions * Add Asciidoc frontmatter * Update "Install and enable" section * Add "Update rules" section * Break out prebuilt rules topic, add images * Add frontmatter, li'l cleanup * Fix x-docs link * Add section on tag categories Addresses #3525 * Revise description frontmatter * Update image, add use case * Update ref in Container Workload Protection * Apply suggestions from reviews 1st round Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Georgii Gorbachev <banderror@gmail.com> * Explain cost of duplicating rules * Rename page Renamed file for good measure (though not necessary) * Tighten up images * Apply feedback from Kseniia * Remove outdated video * Revise & move download section * Apply suggestions from Janeen's review Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * Remove download section, update xref --------- Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Georgii Gorbachev <banderror@gmail.com> Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit 42a3e6c) Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Features/issues covered:
Previews: