chore(NA): enable yarn prefer offline and local mirror for development #84124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
chore
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
spalger
reviewed
Nov 23, 2020
|
Even though we build the coverage system, I wasn't personally responsible for creating the coverage summaries themselves. https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1342/ Note, this is my first time trying to run against a forked branch, hope it works lol |
|
@wayneseymour it looks like it passed 😃 |
wayneseymour
approved these changes
Nov 24, 2020
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
7.x: f93ffd2 |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Nov 25, 2020
elastic#84124) * chore(NA): enable --prefer-offline by default * chore(NA): use prefer offline in the yarnrc * chore(NA): update kbn pm * chore(NA): add yarn offline mirror integration * chore(NA): remove non wanted prune feature due to switching between branches * chore(NA): re-introduce babel require hook # Conflicts: # .ci/packer_cache_for_branch.sh # .gitignore # vars/kibanaCoverage.groovy # vars/kibanaTeamAssign.groovy
mistic
added a commit
that referenced
this pull request
Nov 25, 2020
#84124) (#84297) * chore(NA): enable --prefer-offline by default * chore(NA): use prefer offline in the yarnrc * chore(NA): update kbn pm * chore(NA): add yarn offline mirror integration * chore(NA): remove non wanted prune feature due to switching between branches * chore(NA): re-introduce babel require hook # Conflicts: # .ci/packer_cache_for_branch.sh # .gitignore # vars/kibanaCoverage.groovy # vars/kibanaTeamAssign.groovy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last week when playing with some yarn configs I realised by enabling the
prefer-offline+local mirroron my dev environment I could save up ~20 seconds when doing a cold bootstrap. I'm putting up that PR to ask for your help validating this so we can make everyone else also benefiting from it. Note that I've enabled that option through the.yarnrcflag instead of enabling thekbn bootstapflag in order to already prepare it for the upcoming bazel work over the next months.