Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Enable Detections Coverage Overview dashboard by default #164343

Conversation

banderror
Copy link
Contributor

@banderror banderror commented Aug 21, 2023

Epic: /~https://github.com/elastic/security-team/issues/2905 (internal)

Summary

Enables the Detections Coverage Overview dashboard feature flag by default. We're aiming to release this feature in 8.10.

Before the last BC, we will:

  • remove the flag if we're confident that we should release the feature in 8.10
  • otherwise, revert the flag back to false by default

@banderror banderror added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team ci:cloud-deploy Create or update a Cloud deployment v8.10.0 v8.11.0 labels Aug 21, 2023
@banderror banderror self-assigned this Aug 21, 2023
@banderror banderror requested a review from a team as a code owner August 21, 2023 18:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@banderror banderror requested a review from dplumlee August 21, 2023 18:23
@banderror banderror removed the ci:cloud-deploy Create or update a Cloud deployment label Aug 21, 2023
@banderror banderror force-pushed the enable-coverage-overview-dashboard-by-default branch from 66b457f to 495fe4a Compare August 21, 2023 19:16
@banderror banderror enabled auto-merge (squash) August 21, 2023 19:21
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

  • 💔 Build #152070 failed 66b457f478d0d0c02070af36abf7b4c6b71f27f5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @banderror

@banderror banderror merged commit 43135b6 into elastic:main Aug 21, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 21, 2023
…default (elastic#164343)

**Epic:** elastic/security-team#2905
(internal)

## Summary

Enables the Detections Coverage Overview dashboard feature flag by
default. We're aiming to release this feature in 8.10.

Before the last BC, we will:

- remove the flag if we're confident that we should release the feature
in 8.10
- otherwise, revert the flag back to `false` by default

(cherry picked from commit 43135b6)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 21, 2023
…ard by default (#164343) (#164370)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Security Solution] Enable Detections Coverage Overview dashboard by
default (#164343)](#164343)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](/~https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Georgii
Gorbachev","email":"georgii.gorbachev@elastic.co"},"sourceCommit":{"committedDate":"2023-08-21T20:25:55Z","message":"[Security
Solution] Enable Detections Coverage Overview dashboard by default
(#164343)\n\n**Epic:**
/~https://github.com/elastic/security-team/issues/2905\r\n(internal)\r\n\r\n##
Summary\r\n\r\nEnables the Detections Coverage Overview dashboard
feature flag by\r\ndefault. We're aiming to release this feature in
8.10.\r\n\r\nBefore the last BC, we will:\r\n\r\n- remove the flag if
we're confident that we should release the feature\r\nin 8.10\r\n-
otherwise, revert the flag back to `false` by
default","sha":"43135b6a5dd88f297ec721dc2b9504a16be839e9","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections
and Resp","Team: SecuritySolution","Feature:Rule
Management","Team:Detection Rule
Management","v8.10.0","v8.11.0"],"number":164343,"url":"/~https://github.com/elastic/kibana/pull/164343","mergeCommit":{"message":"[Security
Solution] Enable Detections Coverage Overview dashboard by default
(#164343)\n\n**Epic:**
/~https://github.com/elastic/security-team/issues/2905\r\n(internal)\r\n\r\n##
Summary\r\n\r\nEnables the Detections Coverage Overview dashboard
feature flag by\r\ndefault. We're aiming to release this feature in
8.10.\r\n\r\nBefore the last BC, we will:\r\n\r\n- remove the flag if
we're confident that we should release the feature\r\nin 8.10\r\n-
otherwise, revert the flag back to `false` by
default","sha":"43135b6a5dd88f297ec721dc2b9504a16be839e9"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"/~https://github.com/elastic/kibana/pull/164343","number":164343,"mergeCommit":{"message":"[Security
Solution] Enable Detections Coverage Overview dashboard by default
(#164343)\n\n**Epic:**
/~https://github.com/elastic/security-team/issues/2905\r\n(internal)\r\n\r\n##
Summary\r\n\r\nEnables the Detections Coverage Overview dashboard
feature flag by\r\ndefault. We're aiming to release this feature in
8.10.\r\n\r\nBefore the last BC, we will:\r\n\r\n- remove the flag if
we're confident that we should release the feature\r\nin 8.10\r\n-
otherwise, revert the flag back to `false` by
default","sha":"43135b6a5dd88f297ec721dc2b9504a16be839e9"}}]}]
BACKPORT-->

Co-authored-by: Georgii Gorbachev <georgii.gorbachev@elastic.co>
@banderror banderror deleted the enable-coverage-overview-dashboard-by-default branch August 21, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Rule Management Security Solution Detection Rule Management area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.10.0 v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants