-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Enable Detections Coverage Overview dashboard by default #164343
Merged
banderror
merged 1 commit into
elastic:main
from
banderror:enable-coverage-overview-dashboard-by-default
Aug 21, 2023
Merged
[Security Solution] Enable Detections Coverage Overview dashboard by default #164343
banderror
merged 1 commit into
elastic:main
from
banderror:enable-coverage-overview-dashboard-by-default
Aug 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banderror
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:Detections and Resp
Security Detection Response Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Feature:Rule Management
Security Solution Detection Rule Management area
Team:Detection Rule Management
Security Detection Rule Management Team
ci:cloud-deploy
Create or update a Cloud deployment
v8.10.0
v8.11.0
labels
Aug 21, 2023
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
dplumlee
approved these changes
Aug 21, 2023
banderror
force-pushed
the
enable-coverage-overview-dashboard-by-default
branch
from
August 21, 2023 19:16
66b457f
to
495fe4a
Compare
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @banderror |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 21, 2023
…default (elastic#164343) **Epic:** elastic/security-team#2905 (internal) ## Summary Enables the Detections Coverage Overview dashboard feature flag by default. We're aiming to release this feature in 8.10. Before the last BC, we will: - remove the flag if we're confident that we should release the feature in 8.10 - otherwise, revert the flag back to `false` by default (cherry picked from commit 43135b6)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 21, 2023
…ard by default (#164343) (#164370) # Backport This will backport the following commits from `main` to `8.10`: - [[Security Solution] Enable Detections Coverage Overview dashboard by default (#164343)](#164343) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](/~https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Georgii Gorbachev","email":"georgii.gorbachev@elastic.co"},"sourceCommit":{"committedDate":"2023-08-21T20:25:55Z","message":"[Security Solution] Enable Detections Coverage Overview dashboard by default (#164343)\n\n**Epic:** /~https://github.com/elastic/security-team/issues/2905\r\n(internal)\r\n\r\n## Summary\r\n\r\nEnables the Detections Coverage Overview dashboard feature flag by\r\ndefault. We're aiming to release this feature in 8.10.\r\n\r\nBefore the last BC, we will:\r\n\r\n- remove the flag if we're confident that we should release the feature\r\nin 8.10\r\n- otherwise, revert the flag back to `false` by default","sha":"43135b6a5dd88f297ec721dc2b9504a16be839e9","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Feature:Rule Management","Team:Detection Rule Management","v8.10.0","v8.11.0"],"number":164343,"url":"/~https://github.com/elastic/kibana/pull/164343","mergeCommit":{"message":"[Security Solution] Enable Detections Coverage Overview dashboard by default (#164343)\n\n**Epic:** /~https://github.com/elastic/security-team/issues/2905\r\n(internal)\r\n\r\n## Summary\r\n\r\nEnables the Detections Coverage Overview dashboard feature flag by\r\ndefault. We're aiming to release this feature in 8.10.\r\n\r\nBefore the last BC, we will:\r\n\r\n- remove the flag if we're confident that we should release the feature\r\nin 8.10\r\n- otherwise, revert the flag back to `false` by default","sha":"43135b6a5dd88f297ec721dc2b9504a16be839e9"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"/~https://github.com/elastic/kibana/pull/164343","number":164343,"mergeCommit":{"message":"[Security Solution] Enable Detections Coverage Overview dashboard by default (#164343)\n\n**Epic:** /~https://github.com/elastic/security-team/issues/2905\r\n(internal)\r\n\r\n## Summary\r\n\r\nEnables the Detections Coverage Overview dashboard feature flag by\r\ndefault. We're aiming to release this feature in 8.10.\r\n\r\nBefore the last BC, we will:\r\n\r\n- remove the flag if we're confident that we should release the feature\r\nin 8.10\r\n- otherwise, revert the flag back to `false` by default","sha":"43135b6a5dd88f297ec721dc2b9504a16be839e9"}}]}] BACKPORT--> Co-authored-by: Georgii Gorbachev <georgii.gorbachev@elastic.co>
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Rule Management
Security Solution Detection Rule Management area
release_note:skip
Skip the PR/issue when compiling release notes
Team:Detection Rule Management
Security Detection Rule Management Team
Team:Detections and Resp
Security Detection Response Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
v8.10.0
v8.11.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: /~https://github.com/elastic/security-team/issues/2905 (internal)
Summary
Enables the Detections Coverage Overview dashboard feature flag by default. We're aiming to release this feature in 8.10.
Before the last BC, we will:
false
by default