Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Fix rule severity sorting in inMemory tables #160075

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

jpdjere
Copy link
Contributor

@jpdjere jpdjere commented Jun 20, 2023

Summary

  • Fix rule severity sorting in in-memory tables (Add Rules table and Rule Upgrade table) so that rows are filtered by the semantic meaning of severity.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@jpdjere jpdjere added release_note:fix backport:skip This commit does not require backporting Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area v8.9.0 labels Jun 20, 2023
@jpdjere jpdjere self-assigned this Jun 20, 2023
@jpdjere jpdjere requested a review from a team as a code owner June 20, 2023 19:25
@jpdjere jpdjere requested a review from dplumlee June 20, 2023 19:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@jpdjere jpdjere requested review from xcrzx and removed request for dplumlee June 20, 2023 19:30
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Tests #4 / Alerts generated by building block rules Alerts should be visible on the Rule Detail page and not visible on the Overview page
  • [job] [logs] Investigations - Security Solution Tests #2 / Detection response view Open in timeline "after each" hook for "opens timeline with correct query count for open alerts by rule table"
  • [job] [logs] Investigations - Security Solution Tests #2 / Detection response view Open in timeline opens timeline with correct query count for open alerts by rule table

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.0MB 11.0MB +189.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 411 415 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 494 498 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jpdjere

Copy link
Contributor

@xcrzx xcrzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix, @jpdjere 👍

@xcrzx xcrzx merged commit 5bac117 into elastic:main Jun 21, 2023
@banderror banderror added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Feature:Rule Management Security Solution Detection Rule Management area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants