-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align all usages of Jackson to be 2.14.2 #93438
Align all usages of Jackson to be 2.14.2 #93438
Conversation
…csearch into jakelandis-align_jackson_versions
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Hi @pgomulka, I've created a changelog YAML for you. |
@elasticmachine run elasticsearch-ci/rest-compatibility |
runtimeOnly("com.fasterxml.jackson.core:jackson-databind:2.13.4.2") | ||
runtimeOnly("com.fasterxml.jackson.core:jackson-core:2.13.4") | ||
implementation('com.maxmind.db:maxmind-db:2.1.0') | ||
runtimeOnly("com.fasterxml.jackson.core:jackson-annotations:${versions.jackson}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a matter of fact com.maxmind.geoip2:geoip2
declares its dependencies as
com.fasterxml.jackson.core » jackson-databind 2.13.4.2
com.fasterxml.jackson.core » jackson-core 2.13.4
com.fasterxml.jackson.core » jackson-annotations 2.13.4
so it could be the same argument as in repository-azure? #91725 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with us locking it onto the same version. We could always unlock it in the future if need be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was explicitly unlocked in the past. Upgrading Jackson can sometimes be very difficult. This was decoupled from other uses of Jackson so that we can upgrade them independently. Every time we start using versions.jackson
again, we recouple them.
@elasticmachine run elasticsearch-ci/bwc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This looks good to me, not sure about geoip, but I'd imagine it's fine to upgrade.
upgrading jackson to be 2.14.2 everywhere except for the azure plugin which depends on
and
related: #90553
a replace PR for #91725