-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Change configuration file format to YAML #4456
Conversation
4b678ca
to
ed5b1e7
Compare
ed5b1e7
to
6224040
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #4456 +/- ##
=======================================
Coverage 41.73% 41.73%
=======================================
Files 106 106
Lines 9749 9749
=======================================
Hits 4069 4069
Misses 5333 5333
Partials 347 347
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
6224040
to
28d8200
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In my testing, few of the containers stay running for more than a minute. overrides such as REGISTRY_HOST are not working:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me with the following fix:
ba8bc36
ba8bc36
to
dbe6756
Compare
dbe6756
to
3efd87f
Compare
BREAKING CHANGE: Configuration files are now in YAML format, Defualt file name is now configuration.yaml closes # 4452 Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
3efd87f
to
d085318
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely agree with Farshid's observation that the camelCasing with the lowercase first letter is the preferred style for YAML.
I definitely think we shouldn't hard code jdoe@gmail.com into our scripts!
Though I would approve the PR with it in there, I also don't think we should be suggesting smtp.gmail.com either. I have my printer set up to scan to email via GMail, and no matter how many times I click "allow insecure logins" google turns it back on randomly and my scan to email feature is broken. Suggesting that Gmail is even close to a supportable outgoing SMTP server is just plain misleading.
I googled preferred style for YAML and found there isn't one and found it is dependent on the project. I.e. python projects use lower case hyphenated names. This is why compose files uses lower case hyphenated names. ;-) |
…replaced. Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
fd18b92
to
d35c8a2
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
BREAKING CHANGE: Configuration files are now in YAML format, Default file name is now configuration.yaml
closes # 4452
If your build fails due to your commit message not passing the build checks, please review the guidelines here: /~https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)TBD
Testing Instructions
run
make docker
from compose builder run
make run delayed-start dev
Verify all core/support/security services bootstrap successfully and contain the following log message:
New Dependency Instructions (If applicable)