feat(metadata)!: remove Notifications config #4320

chr1shung · 2023-02-03T03:20:22Z

BREAKING CHANGE: Removed the 'Notifications' config and 'Clients.support-notifications' dependency

in EdgeX 3.0, metadata will leverage device system events to replace the original device change notifications

Signed-off-by: Chris Hung chris@iotechsys.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: /~https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
I am not introducing a new dependency (add notes below if you are)
I have added unit tests for the new feature or bug fix (if not, why?)
I have fully tested (add details below) this the new feature or bug fix (if not, why?)
I have opened a PR for the related docs change (if not, why?)
feat: remove Notifications configuration in Metadata edgex-docs#954

Testing Instructions

New Dependency Instructions (If applicable)

chr1shung · 2023-02-03T03:23:09Z

The function call and code is removed in #4269 so we only removed the config in this PR.
Also might need to update edgex-compose to remove the notifications dependency on metadata ?

codecov-commenter · 2023-02-03T03:57:52Z

Codecov Report

Merging #4320 (372c471) into main (673422c) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #4320   +/-   ##
=======================================
  Coverage   43.15%   43.15%           
=======================================
  Files         116      116           
  Lines       10661    10661           
=======================================
  Hits         4601     4601           
  Misses       5656     5656           
  Partials      404      404

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cloudxxx8 · 2023-02-03T06:59:36Z

yes, edgex-compose should also be updated

in addition, please update the document to remove the related config
https://docs.edgexfoundry.org/2.3/microservices/core/metadata/Ch-Metadata/#configuration-properties

cloudxxx8

LGTM

BREAKING CHANGE: Removed the 'Notifications' config and 'Clients.support-notifications' dependency in EdgeX 3.0, metadata will leverage device system events to replace the original device change notifications closes #4316 Signed-off-by: Chris Hung <chris@iotechsys.com>