Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Eliminate unnamed Kuiper volumes #349

Merged
merged 1 commit into from
Mar 13, 2023
Merged

fix: Eliminate unnamed Kuiper volumes #349

merged 1 commit into from
Mar 13, 2023

Conversation

bnevis-i
Copy link
Collaborator

@bnevis-i bnevis-i commented Mar 7, 2023

When starting the EdgeX framework, a "docker volume ls" command will show three hex-string named volumes that are created as a result of VOLUME declarations in the base image. These volumes correspond to /kuiper/etc, /kuiper/log, and /kuiper/plugins.

This commit explictly mounts named volumes to these locations to stop docker from creating randomly named fill-in volumes.

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) TBD. Tested blocked by another PR.
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Before fix:

  • make clean
  • make run
  • docker volume ls
  • (observe placeholder volumes)

After fix:

  • make clean
  • make run
  • docker volume ls
  • (observe placeholder volumes are replaced with named volumes)

@bnevis-i bnevis-i added this to the Minnesota milestone Mar 7, 2023
@bnevis-i bnevis-i added the tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds label Mar 7, 2023
@bnevis-i bnevis-i requested a review from lenny-goodell March 8, 2023 22:49
@bnevis-i
fix: Eliminate unnamed Kuiper volumes
9b5bde4 
When starting the EdgeX framework, a
"docker volume ls" command will show three
hex-string named volumes that are created
as a result of VOLUME declarations in the
base image. These volumes correspond to
/kuiper/etc, /kuiper/log, and /kuiper/plugins.

This commit explictly mounts named volumes
to these locations to stop docker from
creating randomly named fill-in volumes.

Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>
@bnevis-i bnevis-i marked this pull request as ready for review March 8, 2023 22:54
lenny-goodell
lenny-goodell approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit b680781 into edgexfoundry:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenny-goodell lenny-goodell lenny-goodell approved these changes

Assignees
No one assigned
Labels
tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds
Projects
None yet
Milestone
Minnesota
Development

Successfully merging this pull request may close these issues.
2 participants
@bnevis-i @lenny-goodell