Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make All ProtocolDriver interface API implementations required #1374

Closed
lenny-goodell opened this issue Mar 13, 2023 · 0 comments · Fixed by #1391
Closed

Make All ProtocolDriver interface API implementations required #1374

lenny-goodell opened this issue Mar 13, 2023 · 0 comments · Fixed by #1391
Assignees
@weichou1229
Labels
breaking-change enhancement New feature or request
Milestone
Minnesota

Comments

@lenny-goodell
Copy link
Member

🚀 Feature Request

Relevant Package [REQUIRED]

This feature request is for ProtocolDriver interface

Description [REQUIRED]

The following interfaces are optional for protocol driver to implement since they were added when breaking changes not allowed.

  • Discover()
  • ValidateDevice()

Describe the solution you'd like

It was decide in Device WG on 3/13/2023 to move the above interfaces to the ProtocolDriver interface to that they are required like the existing interfaces. This forces at a minimum an empty implementation which gives exposure to the developer that they exist.

Code in the SDK that checks that these are implemented can be removed.

Describe alternatives you've considered

Leave them as optional.
@lenny-goodell lenny-goodell added the enhancement New feature or request label Mar 13, 2023
@lenny-goodell lenny-goodell added this to the Minnesota milestone Mar 13, 2023
@lenny-goodell lenny-goodell changed the title Make All Driver API implementations required Make All ProtocolDriver interface API implementations required Mar 13, 2023
@cloudxxx8 cloudxxx8 assigned chr1shung and weichou1229 and unassigned chr1shung Mar 14, 2023
weichou1229 added a commit to weichou1229/device-sdk-go that referenced this issue Mar 16, 2023
@weichou1229
feat: Make All ProtocolDriver interface API implementations required
ed3f5dd 
Move Discover(), ValidateDevice() to the ProtocolDriver interface to that they are required like the existing interfaces. This forces at a minimum an empty implementation which gives exposure to the developer that they exist.

Close edgexfoundry#1374

Signed-off-by: bruce <weichou1229@gmail.com>
@weichou1229 weichou1229 mentioned this issue Mar 16, 2023
Merged
5 tasks
weichou1229 added a commit to weichou1229/device-sdk-go that referenced this issue Mar 16, 2023
@weichou1229
feat: Make All ProtocolDriver interface API implementations required
76e331e 
BREAKING CHANGE: Move Discover(), ValidateDevice() to the ProtocolDriver interface to that they are required like the existing interfaces. This forces at a minimum an empty implementation which gives exposure to the developer that they exist.

Close edgexfoundry#1374

Signed-off-by: bruce <weichou1229@gmail.com>
weichou1229 added a commit to weichou1229/device-sdk-go that referenced this issue Mar 17, 2023
@weichou1229
feat: Make All ProtocolDriver interface API implementations required
73c8a74 
Move Discover(), ValidateDevice() to the ProtocolDriver interface to that they are required like the existing interfaces. This forces at a minimum an empty implementation which gives exposure to the developer that they exist.

Close edgexfoundry#1374

Signed-off-by: bruce <weichou1229@gmail.com>
weichou1229 added a commit to weichou1229/device-sdk-go that referenced this issue Mar 17, 2023
@weichou1229
feat: Make All ProtocolDriver interface API implementations required
87dd5f7 
Move Discover(), ValidateDevice() to the ProtocolDriver interface to that they are required like the existing interfaces. This forces at a minimum an empty implementation which gives exposure to the developer that they exist.

Close edgexfoundry#1374

Signed-off-by: bruce <weichou1229@gmail.com>
weichou1229 added a commit to weichou1229/device-sdk-go that referenced this issue Mar 20, 2023
@weichou1229
feat!: Make All ProtocolDriver interface API implementations required
ebc6224 
Move Discover(), ValidateDevice() to the ProtocolDriver interface to that they are required like the existing interfaces. This forces at a minimum an empty implementation which gives exposure to the developer that they exist.

Close edgexfoundry#1374

Signed-off-by: bruce <weichou1229@gmail.com>
weichou1229 added a commit to weichou1229/device-sdk-go that referenced this issue Mar 20, 2023
@weichou1229
feat!: Make All ProtocolDriver interface API implementations required
8f5fed3 
Move Discover(), ValidateDevice() to the ProtocolDriver interface to that they are required like the existing interfaces. This forces at a minimum an empty implementation which gives exposure to the developer that they exist.

Close edgexfoundry#1374

Signed-off-by: bruce <weichou1229@gmail.com>
weichou1229 added a commit to weichou1229/device-sdk-go that referenced this issue Mar 21, 2023
@weichou1229
feat!: Refactor Bootstrap and NewDeviceService parameter
10d5e12 
Use interfaces.ProtocolDriver instead of any as parameter.

Close edgexfoundry#1374

Signed-off-by: bruce <weichou1229@gmail.com>
weichou1229 added a commit to weichou1229/device-sdk-go that referenced this issue Mar 22, 2023
@weichou1229
feat!: Refactor Bootstrap and NewDeviceService parameter
3208d00 
Use interfaces.ProtocolDriver instead of any as parameter.

Close edgexfoundry#1374

Signed-off-by: bruce <weichou1229@gmail.com>
cloudxxx8 pushed a commit that referenced this issue Apr 7, 2023
@weichou1229
feat!: Make All ProtocolDriver interface API implementations required (…
d73da92 
…#1391)

* feat!: Make All ProtocolDriver interface API implementations required

Move Discover(), ValidateDevice() to the ProtocolDriver interface to that they are required like the existing interfaces. This forces at a minimum an empty implementation which gives exposure to the developer that they exist.

Close #1374

Signed-off-by: bruce <weichou1229@gmail.com>

* feat!: Refactor Bootstrap and NewDeviceService parameter

Use interfaces.ProtocolDriver instead of any as parameter.

Close #1374

Signed-off-by: bruce <weichou1229@gmail.com>

---------

Signed-off-by: bruce <weichou1229@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weichou1229 weichou1229

Labels
breaking-change enhancement New feature or request
Projects
None yet
Milestone
Minnesota
Development

Successfully merging a pull request may close this issue.

feat!: Make All ProtocolDriver interface API implementations required weichou1229/device-sdk-go
3 participants
@weichou1229 @chr1shung @lenny-goodell