Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin] load VS Code extensions from sources #3976

Closed
akosyakov opened this issue Jan 8, 2019 · 2 comments · Fixed by #3977
Closed

[plugin] load VS Code extensions from sources #3976

akosyakov opened this issue Jan 8, 2019 · 2 comments · Fixed by #3977
Assignees
@akosyakov
Labels
enhancement issues that are enhancements to current functionality - nice to haves plug-in system issues related to the plug-in system

Comments

@akosyakov
Copy link
Member

No description provided.

@akosyakov akosyakov self-assigned this Jan 8, 2019
@akosyakov akosyakov added plug-in system issues related to the plug-in system enhancement issues that are enhancements to current functionality - nice to haves labels Jan 8, 2019
@benoitf
Copy link
Contributor

benoitf commented Jan 8, 2019

what is the description ?

@akosyakov
Copy link
Member Author

VS Code does not package built-in extension in vsix, but minify via wepback and consume from sources. I've tried to package them first myself, but it fails with different errors because of missing attributes and so on. Then I went with VS Code approach to load from sources and added custom directory handler: /~https://github.com/theia-ide/vscode-builtin-extensions/blob/master/vscode-builtin-extensions/src/node/vscode-builtin-extension-directory-handler.ts

Now, I want to test my changes for #3972 against bat built-in extension. But to load it I need to integrate VSCodeBuiltinExtensionDirectoryHandler into the plugin-ext-vscode.

Also, It will be good later for development of VS Code extensions.

akosyakov added a commit that referenced this issue Jan 9, 2019
@akosyakov
[plugin] fix #3976: resolve VS Code from sources
05ecfa6 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
This was referenced Jan 9, 2019
Merged
Closed
akosyakov added a commit that referenced this issue Jan 10, 2019
@akosyakov
[plugin] fix #3976: resolve VS Code from sources
ed0a7d5 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 11, 2019
@akosyakov
[plugin] fix #3976: resolve VS Code from sources
3225028 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
bogthe pushed a commit to ARMmbed/theia that referenced this issue Jan 21, 2019
@akosyakov
[plugin] fix eclipse-theia#3976: resolve VS Code from sources
62774cf 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Bogdan Stolojan <petre.stolojan@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
enhancement issues that are enhancements to current functionality - nice to haves plug-in system issues related to the plug-in system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[plugin] basic support of snippets eclipse-theia/theia
2 participants
@benoitf @akosyakov