Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#401] Lock-free Atomics for 32-bit architectures #403

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Sep 27, 2024

Notes for Reviewer

This PR enables lock-free atomics for 32-bit architectures. Since all common 32-bit architectures support 8 byte CAS operations, the reader-writer lock implementation is not required.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Closes #401

@elBoberido elBoberido self-assigned this Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.96%. Comparing base (da1ec61) to head (453dada).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   78.99%   78.96%   -0.04%     
==========================================
  Files         194      194              
  Lines       22730    22730              
==========================================
- Hits        17955    17948       -7     
- Misses       4775     4782       +7     
Files with missing lines Coverage Δ
iceoryx2-pal/concurrency-sync/src/iox_atomic.rs 96.19% <ø> (ø)

... and 9 files with indirect coverage changes

@elBoberido
Copy link
Member Author

We reached the Cirrus CI limit. Merging anyway since the github CI is our main CI.

@elBoberido elBoberido merged commit a9cc0a3 into eclipse-iceoryx:main Sep 27, 2024
48 of 56 checks passed
@elBoberido elBoberido deleted the iox2-401-lock-free-atomics-for-32-bit branch September 27, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lock-free atomics on 32-bit architectures
2 participants