fix(plugins): Change path to plugins index.json file

[vitaliy-guliy]

Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com

What does this PR do?

When Che is deployed in single-host mode, the plugin registry does not respect index.json file, where all the plugins are described.
For that case, it's better to read plugins.json file directly.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#19955

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=next

[benoitf]

hello, is it related to a missing / at the end of the URL ?
for example
https://che-eclipse-che.apps.cluster-91de.91de.sandbox1444.opentlc.com/plugin-registry/v3/plugins/ works
https://che-eclipse-che.apps.cluster-91de.91de.sandbox1444.opentlc.com/plugin-registry/v3/plugins redirect to dashboard

[vitaliy-guliy]

hello, is it related to a missing / at the end of the URL ?
for example
https://che-eclipse-che.apps.cluster-91de.91de.sandbox1444.opentlc.com/plugin-registry/v3/plugins/ works
https://che-eclipse-che.apps.cluster-91de.91de.sandbox1444.opentlc.com/plugin-registry/v3/plugins redirect to dashboard

yes.
The same issue we have for devfile registry.

[benoitf]

my question is: should we not fix the URL just by appending a single / instead of specifying /index.json ?

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (main@af569ae). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1154   +/-   ##
=======================================
  Coverage        ?   32.79%           
=======================================
  Files           ?      290           
  Lines           ?     9886           
  Branches        ?     1457           
=======================================
  Hits            ?     3242           
  Misses          ?     6641           
  Partials        ?        3           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af569ae...a841f43. Read the comment docs.

[che-bot]

❌ E2E Happy path tests failed ❗

See Details

• Jenkins job

• test report

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	quay.io/crw_pr/che-theia:1154
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1154

Test product:

• tested with Eclipse Che on K8S (minikube v1.1.1)
• E2E test scenario
• E2E test pipeline source code

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

[vitaliy-guliy]

my question is: should we not fix the URL just by appending a single / instead of specifying /index.json ?

What if it's a custom registry (surge.sh, etc), that is running not under apache, where index.json is not configured as directory index?
Then getting of the index file will be impossible.

In our case we always generate index.json file /~https://github.com/eclipse-che/che-plugin-registry/blob/main/tools/build/src/meta-yaml/index-writer.ts#L44, why not to read it by explicit link?

[benoitf]

well, I would say index.json is an implementation detail of the plug-in registry
as it's "emulating REST API' with / I would say it's better to use 'REST' calls so even if index.json become index.foo or is totally removed we're still safe.

[vitaliy-guliy]

Reworked on adding only '/plugins/' at the end.

[vitaliy-guliy]

But we also need to investigate a bit the apache server.
In single host mode it generates wrong redirect link.

If you try

curl -v https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/plugin-registry/v3/plugins

you will get

HTTP/1.1 301 Moved Permanently
location: http://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/v3/plugins/

Location URI does not contain /plugin-registry anymore.

[benoitf]

@vitaliy-guliy might be related to eclipse-che/che#19995

[che-bot]

❌ E2E Happy path tests failed ❗

See Details

• Jenkins job

• test report

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	quay.io/crw_pr/che-theia:1154
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1154

Test product:

• tested with Eclipse Che on K8S (minikube v1.1.1)
• E2E test scenario
• E2E test pipeline source code

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

[vitaliy-guliy]

[crw-ci-test --rebuild]

[che-bot]

❌ E2E Happy path tests failed ❗

See Details

• Jenkins job

• test report

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	quay.io/crw_pr/che-theia:1154
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1154

Test product:

• tested with Eclipse Che on K8S (minikube v1.1.1)
• E2E test scenario
• E2E test pipeline source code

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

[dmytro-ndp]

@vitaliy-guliy: recent execution of Happy path test has failed because of known issue eclipse-che/che#18034

[vitaliy-guliy]

@vitaliy-guliy: recent execution of Happy path test has failed because of known issue eclipse/che#18034

Thanks for your comment.
Merging the PR as there is Happy Path / happy-path (alpine, next) (pull_request) passes.