-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge meta.yaml and plugin yaml in v3 #135
Conversation
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the files embedded in containers are vs code extensions (not theia plugin) and I would expect this to become more and more the case (do we really need theia plugins after all? isn't it just confusing to support both? plugins may be replaced by vs code extensions in the future). Hence extensions
would be better than plugins
. Otherwise you can use references
or even just files
.
Makes sense. I'll go with field name |
@l0rd changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the only thing that I'm a bit baffled with is that v3
plugins have v2
API version. Should not those 2 be consistent to avoid confusion? I thought that:
v1 - first version of plugins we had
v2 - naming convention changes
v3 - new format of meta.yaml (this PR)
@ibuziuk we have different folders for different versions of the registry, but this doesn't mean those versions use different format of meta.yaml. |
What does this PR do?
Merge meta.yaml and plugin yaml and put it to v3 folder as described here.
One thing that I changed comparing to the comment linked above is that now both theia and vscode plugins are using field
plugins
to refer to the archives of the plugins.Example of theia plugin:
And example of vscode plugin:
@l0rd how do you think is it OK to refer to archives as
plugins
in both of them? Should we change toextensions
for vscode andplugins
for theia or should we use something completely different, like archives?@tsmaeder FYI you can see in this PR how it will be possible to configure env vars, memory, volumes, etc for vscode extension in the registry. In this PR, in particular, VSCode extensions metas contain only container image, but since foramt is absolutely the same as with editors you can see how to do it in the theia meta, for example.