This repository has been archived by the owner on May 7, 2020. It is now read-only.
fix race condition which could leave a thing in INITIALIZING #3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as we have seen in eclipse-archived#2945 and eclipse-archived#3015, there can be situations when a thing is left in INITIALIZING state although the binding updated its state correctly. The root cause was a race condition between ThingManager and GenericThingProvider. While the ThingManager was trying to initialize the Thing, the GenericThingProvider tried to update the the existing thing (which already had a ThingHandler). As a result, the existing ThingHandler updated the outdated thing, not knowing that there actually was an update. The key for fixing this was changing the point in time when a handler is created. This will now also be postponed until the binding is fully loaded. Additionally, bindings have to deal with thing updates while the thing still is in INITIALIZING state. On the other hand, it is now technically prevented that ThingHandler.initialize() can get called again when a thing already is ONLINE/OFFLINE/UNKNOWN. fixes eclipse-archived#2945 fixes eclipse-archived#3015 Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
kaikreuzer
approved these changes
Mar 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as we have seen in #2945 and #3015, there can be situations when a thing
is left in INITIALIZING state although the binding updated its state
correctly.
The root cause was a race condition between ThingManager and GenericThingProvider.
While the ThingManager was trying to initialize the Thing, the GenericThingProvider
tried to update the the existing thing (which already had a ThingHandler). As a
result, the existing ThingHandler updated the outdated thing, not knowing that
there actually was an update.
The key for fixing this was changing the point in time when a handler is created.
This will now also be postponed until the binding is fully loaded. Additionally,
bindings have to deal with thing updates while the thing still is in INITIALIZING
state. On the other hand, it is now technically prevented that ThingHandler.initialize()
can get called again when a thing already is ONLINE/OFFLINE/UNKNOWN.
fixes #2945
fixes #3015
Signed-off-by: Simon Kaufmann simon.kfm@googlemail.com