Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20091] Add actions to support Fast DDS CI on macOS #44

Merged
merged 9 commits into from
Feb 20, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Dec 6, 2023

This PR adds/modifies the necessary actions to support running Fast DDS CI on macOS Github-hosted runners.

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz force-pushed the feature/fastdds_mac_ci_support branch 5 times, most recently from 5d6993d to a06b03a Compare February 17, 2024 16:31
@EduPonz EduPonz force-pushed the feature/fastdds_mac_ci_support branch 7 times, most recently from 268e8af to bd71eaa Compare February 18, 2024 08:33
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz force-pushed the feature/fastdds_mac_ci_support branch from bd71eaa to 8b7b8e4 Compare February 18, 2024 08:43
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest updating the README with the new feature.

Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

multiplatform/colcon_test/action.yml Outdated Show resolved Hide resolved
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the README

Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please, remember to update all @feature/fastdds_mac_ci_support to @main before merging

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz merged commit b8277cd into main Feb 20, 2024
1 check passed
@EduPonz EduPonz deleted the feature/fastdds_mac_ci_support branch February 20, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants